Only list linked issues once in release issues #20299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This shuffles the entries’ ordering though. Would that be a problem? |
kaxil
approved these changes
Dec 15, 2021
kaxil
added
the
changelog:skip
Member
Author
|
@uranusjr no, the order doesn't matter. |
github-actions
bot
added
the
okay to merge
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
pushed a commit
that referenced
this pull request
Jan 22, 2022
(cherry picked from commit 58464d8)
jedcunningham
added a commit
that referenced
this pull request
Jan 27, 2022
(cherry picked from commit 58464d8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we had duplicate linked issues sometimes, so toss them into a set first to dedup them.
This can happen when a given issue is mentioned more than once, e.g: #19616.