Skip to content

Conversation

@rustikk
Copy link
Contributor

@rustikk rustikk commented Jan 3, 2022

closes: #20545
Fixed docs for time and random macros as the reference to what they were was incorrect.

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 3, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@kaxil kaxil added this to the Airflow 2.2.4 milestone Jan 4, 2022
@kaxil kaxil changed the title changed macros to correct classes and modules Docs: Changed macros to correct classes and modules Jan 4, 2022
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jan 4, 2022
@kaxil
Copy link
Member

kaxil commented Jan 4, 2022

Thanks for the fix @rustikk 🎉

@kaxil kaxil merged commit 8b2299b into apache:main Jan 4, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 4, 2022

Awesome work, congrats on your first merged pull request!

@rustikk
Copy link
Contributor Author

rustikk commented Jan 5, 2022

@kaxil I'm happy to help :)

@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 20, 2022
jedcunningham pushed a commit that referenced this pull request Jan 21, 2022
closes: #20545
Fixed docs for time and random macros as the reference to what they are was incorrect.

(cherry picked from commit 8b2299b)
@potiuk potiuk added type:doc-only Changelog: Doc Only and removed changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) labels Jan 22, 2022
@jedcunningham jedcunningham added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:doc-only Changelog: Doc Only labels Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

built in macros (macros.random, macros.time) need documentation change

4 participants