Clarify sentry_on value is not quoted with example
#20639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfier
changed the title
sentry_on value is not quoted with example
kaxil
reviewed
Jan 4, 2022
Member
There was a problem hiding this comment.
Suggested change
| After that, you need to enable the integration by set ``sentry_on`` option in ``[sentry]`` section to ``'True'``. | |
| After that, you need to enable the integration by set ``sentry_on`` option in ``[sentry]`` section to ``True``. |
Contributor
Author
There was a problem hiding this comment.
Should I remove the single quotes for sentry_dsn as well?
Member
There was a problem hiding this comment.
+1 to removing quotes to both. These are INI, not Python, the quotes just shouldn’t exist in the first place.
uranusjr
approved these changes
Jan 5, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
approved these changes
Jan 5, 2022
jedcunningham
added
the
changelog:skip
jedcunningham
pushed a commit
that referenced
this pull request
Jan 21, 2022
Clarify the value for ``sentry_on`` is not quoted by providing an example. (cherry picked from commit e8b5ab9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the value for
sentry_onis not quoted by providing an example.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.