Skip to content

Conversation

@eladkal
Copy link
Contributor

@eladkal eladkal commented Jan 6, 2022

Final PR to close: #20296

Replace #20418


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@eladkal
Copy link
Contributor Author

eladkal commented Jan 7, 2022

Ready for review :)
cc @ferruzzi

Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of notes.

Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jan 8, 2022
@github-actions
Copy link

github-actions bot commented Jan 8, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@eladkal eladkal merged commit 6776586 into apache:main Jan 9, 2022
@eladkal eladkal deleted the sqs branch January 9, 2022 05:51
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge kind:documentation provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistently name Amazon provider operators files

4 participants