Better multiple_outputs inferral for @task.python #20800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
covert-test-python
branch
2 times, most recently
from
7209175 to
29b3d8a
Compare
ashb
approved these changes
Jan 26, 2022
This switches the implementation from using inspect.signature() (which uses __annotations__ internally) to typing.get_type_hints() to provide better type resolution from "stringified" annotations. This better supports 'from __future__ import annotation' and other non-define-time resolved annotations. To improve test writability and readability, TestAirflowTaskDecorator is converted from unittest to pytest-style for better version-based test-skipping fuinctionalities.
uranusjr
force-pushed
the
covert-test-python
branch
from
29b3d8a to
db3bb99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #19608 and switches the implementation from using
inspect.signature()(which uses__annotations__internally) totyping_extension.get_type_hints()(not thetypingone for better backward compatibility) to provide better type resolution from “stringified” annotations. This better supportsfrom __future__ import annotationand other non-define-time resolved annotations.To improve test writability and readability,
TestAirflowTaskDecoratoris converted from unittest to pytest-style for better version-based test-skipping fuinctionalities.cc @josh-fell