Skip to content

Fix type annotations re task decorator map #21402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dstandish wants to merge 7 commits into from
Closed

Fix type annotations re task decorator map #21402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e95b5df
Fix type annotations re task decorator map
dstandish Feb 7, 2022
67e2f0f
try fix
dstandish Feb 7, 2022
5c22771
try other fix
dstandish Feb 7, 2022
3bc17bd
try kwarg
dstandish Feb 7, 2022
c68fa59
try using protocols
dstandish Feb 7, 2022
31ea94e
revert protocol change
dstandish Feb 7, 2022
d7b73db
ignore type
dstandish Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion airflow/decorators/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@

from typing import Any, Callable, Dict, Iterable, List, Mapping, Optional, TypeVar, Union, overload

from mypy_extensions import KwArg

from airflow.decorators.base import TaskDecorator
from airflow.decorators.python import python_task
from airflow.decorators.python_virtualenv import virtualenv_task
Expand Down Expand Up @@ -226,4 +228,5 @@ class TaskDecoratorCollection:
"""
# [END decorator_signature]

task: TaskDecoratorCollection
DecoratedTaskType = Callable[[Function], TaskDecoratorCollection]
task: Union[DecoratedTaskType, Callable[[..., KwArg()], DecoratedTaskType]]
2 changes: 1 addition & 1 deletion airflow/providers/influxdb/example_dags/example_influxdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
from airflow.providers.influxdb.hooks.influxdb import InfluxDBHook


@task(task_id="influxdb_task")
@task(task_id="influxdb_task") # type: ignore
def test_influxdb_hook():
bucket_name = 'test-influx'
influxdb_hook = InfluxDBHook()
Expand Down