Skip to content

Conversation

@zhongjiajie
Copy link
Member

for now, our s3 bucket example does without declaring task upload_keys but we set dependence with it. I think we should better add upload_keys declare to the example for more sence.
image

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Feb 8, 2022
@zhongjiajie zhongjiajie requested review from mik-laj and potiuk February 8, 2022 10:50
@ferruzzi
Copy link
Contributor

ferruzzi commented Feb 8, 2022

I can see what you are saying, yeah. I'm working on planning a bit of a project to get a lot of the AWS examples and docs up to par, so there should be a lot of improvements in that area in the near future. I'll keep cases like this in mind.

@zhongjiajie
Copy link
Member Author

@ferruzzi So should we merge or should we just close this issue?

@ferruzzi
Copy link
Contributor

@zhongjiajie I say go ahead, it's non-breaking either way and I think we're going to focus on the ones that don't have any documentation or sample DAGs first so I don't see a reason to block this just because we might update it later. I'm not a committer but you have my non-binding approval :P

@potiuk potiuk merged commit 8e81615 into apache:main Feb 11, 2022
@zhongjiajie zhongjiajie deleted the doc-imp-ex-s3-include-task-upload-key branch February 11, 2022 12:04
@zhongjiajie
Copy link
Member Author

Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants