Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Feb 19, 2022

Amazon SES Had a wrong signature to become a mailer in Airflow
introduced in #18042. As the result setting SES emailer as
email backend resulted in:

TypeError: send_email() missing 1 required positional argument:
'html_content'

Fixes: #21671


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Amazon SES Had a wrong signature to become a mailer in Airflow
introduced in apache#18042. As the result setting SES emailer as
email backend resulted in:

```
TypeError: send_email() missing 1 required positional argument:
'html_content'
```

Fixes: apache#21671
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 19, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit b28f4c5 into apache:main Feb 19, 2022
@potiuk potiuk deleted the fix-amazon-send-email-signature branch February 19, 2022 09:34
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 28, 2022
@potiuk potiuk restored the fix-amazon-send-email-signature branch April 26, 2022 20:48
@potiuk potiuk deleted the fix-amazon-send-email-signature branch July 29, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Amazon Airflow Provider | Broken AWS SES as backend for Email

3 participants