Skip to content

Conversation

@EricGao888
Copy link
Member

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 24, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Feb 27, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member

potiuk commented Feb 28, 2022

Some static checks/docs are failing.

@EricGao888
Copy link
Member Author

Some static checks/docs are failing.

I've fixed the checks/docs failures in the latest commit. Thx for the reminder.

@EricGao888
Copy link
Member Author

@mik-laj Could you please take a look at this pr? BTW, I will fix the unit tests in alibaba provider in a separate pr, using unittest.mock to replace the real external storage during unit test. THX

@potiuk
Copy link
Member

potiuk commented Mar 7, 2022

You need to rebase @EricGao888

@EricGao888
Copy link
Member Author

You need to rebase @EricGao888

@potiuk Thanks for the reminder! I will rebase it, resolve the comments above and submit a new commit today.

@EricGao888
Copy link
Member Author

@potiuk @mik-laj In the latest commit, I've resolved all the comments above, fixed minor bugs, added more unit tests for oss hook and oss task handler. Also, the unit tests in oss task handler are all switched to use mocks instead of connecting to a real OSS. PTAL. Thx : )

@potiuk
Copy link
Member

potiuk commented Mar 8, 2022

LGTM. @mik-laj ?

@potiuk
Copy link
Member

potiuk commented Mar 8, 2022

@EricGao888 - just the few suggestions from @mik-laj and we can merge it :)

@EricGao888
Copy link
Member Author

@EricGao888 - just the few suggestions from @mik-laj and we can merge it :)

Done : ) Thx for the review @potiuk @mik-laj

@EricGao888
Copy link
Member Author

Seems docs build failed. Not sure whether should I rebase again? Looks like related: #22100

@EricGao888
Copy link
Member Author

Seems docs build failed. Not sure whether should I rebase again? Looks like related: #22100

@potiuk May I ask is there anything else I need to do to get this pr merged?

@mik-laj
Copy link
Member

mik-laj commented Mar 10, 2022

@EricGao888 I rebased this PR.

@EricGao888
Copy link
Member Author

@potiuk @mik-laj Seems ready to be merged. Would you like to help me merge the commits? Thx!

@potiuk potiuk merged commit 7bd8b2d into apache:main Mar 11, 2022
@EricGao888 EricGao888 deleted the Fix-21748 branch March 11, 2022 12:55
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logging area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add oss_task_handler for alibaba provider

4 participants