-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Update google-cloud-spanner version #21890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@potiuk Could you assign someone to review? |
|
To add support for airflow/airflow/providers/snowflake/hooks/snowflake.py Lines 216 to 219 in 33edeb2
|
|
Rebased it to latest main - let's see if it works. |
|
@mik-laj When we add |
|
@lwyszomi , Yes. Thanks to this, we will be able to use it in other places where DBApiHook class is expected. Users will also not need to study this class specifically, as they will be able to rely on a unified interface. |
|
@mik-laj I have one more think in my mind, if we extend this hook maybe by default we should add |
|
Yep. Good idea. |
|
@potiuk @mik-laj This change for now is blocked because we have a issue with the dependencies. The Airflow supporting |
Too bad. I opened issue for that: googleapis/python-spanner-sqlalchemy#204 |
|
@potiuk thanks |
|
Apparently, support (and test case suite) was added in January but the setup.py has not been updated :) googleapis/python-spanner-sqlalchemy#204 (comment) 🤷 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
|
@lwyszomi - seems like Google Spanner now suports sqlalchemy 1.4 googleapis/python-spanner-sqlalchemy#204 - feel free to provide support for it :) |
Update package to give users possibility to install
sqlalchemy-spanner.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.