Skip to content

Conversation

@patricker
Copy link
Contributor

closes: #21978


Adds an optional parameter to the GCS Hook Upload method to allow metadata to be uploaded alongside the GCS file.

@patricker patricker requested a review from turbaszek as a code owner March 7, 2022 20:19
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Mar 7, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 7, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@patricker patricker force-pushed the gcs_upload_metadata branch from ab174a4 to 1bb5119 Compare March 7, 2022 21:19
@potiuk potiuk merged commit a11d831 into apache:main Mar 7, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 7, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Metadata Upload Support to GCSHook Upload Method

2 participants