Bug-fix GCSToS3Operator #22071
Merged
Bug-fix GCSToS3Operator #22071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
potiuk
approved these changes
Mar 8, 2022
41 tasks
rafalh
reviewed
Mar 20, 2022
| ) | ||
|
|
||
| if not self.keep_directory_structure and self.prefix: | ||
| self.dest_s3_key = os.path.join(self.dest_s3_key, self.prefix) |
Contributor
There was a problem hiding this comment.
will it work properly on Windows where os.path.join uses backslashes (\)? I think it should use posixpath instead
Member
There was a problem hiding this comment.
Feel free to make PR. Airflow only works on POSIX (for multiple reasons) but you are right it would be beter to even hardcode "/'".
Contributor
Author
There was a problem hiding this comment.
Will remember to use posixpath going forward. Actually, I referred to some of the code here when I did my PR.
Let me know if I should do the fix, I can get to it over the weekend..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #18267
Implements an option to
keep_directory_structure.True: Keep the destination directory structure
False: Create the source directory structure as specified by
prefix^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.