Skip to content

AWS RDS integration fixes #22125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 1 commit into from
Mar 13, 2022
Merged

AWS RDS integration fixes #22125

potiuk merged 1 commit into from
Mar 13, 2022

Conversation

@kazanzhy
Copy link
Contributor

@kazanzhy kazanzhy commented Mar 9, 2022 •
edited
Loading

AWS RDS integration fixes for:
#20642
#20907
#21231

Screenshot 2022-03-09 at 18 25 12

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Mar 9, 2022
@kazanzhy kazanzhy mentioned this pull request Mar 9, 2022
Closed
84 tasks
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 9, 2022
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@kazanzhy kazanzhy force-pushed the rds_integration_fix branch from 70dff34 to 291b233 Compare March 10, 2022 12:56
@eladkal
Copy link
Contributor

eladkal commented Mar 10, 2022

rds tests are failing :(

@potiuk
Copy link
Member

potiuk commented Mar 11, 2022

Yeah will need to wait for amazon release for that one.

@kazanzhy
Copy link
Contributor Author

kazanzhy commented Mar 11, 2022 •
edited
Loading

My bad. That's my own bug that I've put to moto.
Fixing it by this PR getmoto/moto#4930

Also, since I started implementing this integration @mock_rds2 become deprecated and all functionality is available in @mock_rds

@kazanzhy kazanzhy force-pushed the rds_integration_fix branch 3 times, most recently from cc0dd6b to 5aa0c7d Compare March 11, 2022 21:30
@potiuk potiuk closed this Mar 11, 2022
@potiuk potiuk reopened this Mar 11, 2022
@kazanzhy kazanzhy force-pushed the rds_integration_fix branch from 5aa0c7d to 480ff01 Compare March 12, 2022 22:54
@kazanzhy
Copy link
Contributor Author

kazanzhy commented Mar 13, 2022

A new moto version was released recently.
So I can say that operators work as expected with real AWS and moto as well.

potiuk
potiuk approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Constraints failed but it basically means we have to refresh them manually in this case I will take care of it.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 13, 2022
@github-actions
Copy link

github-actions bot commented Mar 13, 2022

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member

potiuk commented Mar 13, 2022

Updated constraints manually. Merging.

@potiuk potiuk merged commit a840561 into apache:main Mar 13, 2022
@potiuk potiuk mentioned this pull request Mar 15, 2022
Closed
41 tasks
@kazanzhy kazanzhy deleted the rds_integration_fix branch April 5, 2022 15:34
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

Assignees

No one assigned

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kazanzhy @eladkal @potiuk @ephraimbuddy