Skip to content

Conversation

@zachliu
Copy link
Contributor

@zachliu zachliu commented Mar 10, 2022

🐛 fix for #22002


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Mar 10, 2022
@potiuk potiuk force-pushed the ecsoperator-retry-on-eni-provisioning-failures branch 2 times, most recently from 30a0b5c to fdee933 Compare March 10, 2022 11:55
@zachliu zachliu force-pushed the ecsoperator-retry-on-eni-provisioning-failures branch from 7a86e31 to acceacd Compare March 10, 2022 15:45
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 10, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 16ad03c into apache:main Mar 10, 2022
@zachliu zachliu deleted the ecsoperator-retry-on-eni-provisioning-failures branch March 11, 2022 03:00
@zachliu
Copy link
Contributor Author

zachliu commented Mar 14, 2022

@potiuk now i have definitive proof that this works like 99% perfectly:

[2022-03-12, 07:20:05 EST] {{before.py:35}} INFO - Starting call to 'airflow.providers.amazon.aws.operators.ecs.EcsOperator._start_wait_check_task', this is the 1st time calling it.
[2022-03-12, 07:20:06 EST] {{ecs.py:371}} INFO - ECS Task started: ...
[2022-03-12, 07:20:06 EST] {{ecs.py:375}} INFO - ECS task ID is: a52de9c027c14052a9c93933a8dc0958
[2022-03-12, 07:20:06 EST] {{ecs.py:321}} INFO - Starting ECS Task Log Fetcher
[2022-03-12, 07:20:21 EST] {{base_aws.py:100}} INFO - Retrieving region_name from Connection.extra_config['region_name']
[2022-03-12, 07:23:37 EST] {{ecs.py:448}} INFO - ECS Task stopped, check status: ...
[2022-03-12, 07:23:37 EST] {{before.py:35}} INFO - Starting call to 'airflow.providers.amazon.aws.operators.ecs.EcsOperator._start_wait_check_task', this is the 1st time calling it.
[2022-03-12, 07:23:47 EST] {{before.py:35}} INFO - Starting call to 'airflow.providers.amazon.aws.operators.ecs.EcsOperator._start_wait_check_task', this is the 2nd time calling it.
[2022-03-12, 07:23:47 EST] {{ecs.py:371}} INFO - ECS Task started: ...

with the 1% imperfection being the duplicate log entry...
it is because in the base_aws.py we used the same logger for both before and after:

'before': tenacity_logger,
'after': tenacity_logger,

another simple PR coming right up

@potiuk
Copy link
Member

potiuk commented Mar 14, 2022

another simple PR coming right up

JUST In time for the next provider's release :D

zachliu added a commit to zachliu/airflow that referenced this pull request Mar 14, 2022
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 10, 2022
apache/airflow#22137 (comment)

GitOrigin-RevId: 4f6d24f8658e0896c46e613aa656a853b358c321
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 30, 2022
apache/airflow#22137 (comment)

GitOrigin-RevId: 4f6d24f8658e0896c46e613aa656a853b358c321
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022
apache/airflow#22137 (comment)

GitOrigin-RevId: 4f6d24f8658e0896c46e613aa656a853b358c321
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022
apache/airflow#22137 (comment)

GitOrigin-RevId: 4f6d24f8658e0896c46e613aa656a853b358c321
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
apache/airflow#22137 (comment)

GitOrigin-RevId: 4f6d24f8658e0896c46e613aa656a853b358c321
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
apache/airflow#22137 (comment)

GitOrigin-RevId: 4f6d24f8658e0896c46e613aa656a853b358c321
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024
apache/airflow#22137 (comment)

GitOrigin-RevId: 4f6d24f8658e0896c46e613aa656a853b358c321
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2024
apache/airflow#22137 (comment)

GitOrigin-RevId: 4f6d24f8658e0896c46e613aa656a853b358c321
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 7, 2024
apache/airflow#22137 (comment)

GitOrigin-RevId: 4f6d24f8658e0896c46e613aa656a853b358c321
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 2, 2025
apache/airflow#22137 (comment)

GitOrigin-RevId: 4f6d24f8658e0896c46e613aa656a853b358c321
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request May 23, 2025
apache/airflow#22137 (comment)

GitOrigin-RevId: 4f6d24f8658e0896c46e613aa656a853b358c321
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 18, 2025
apache/airflow#22137 (comment)

GitOrigin-RevId: 4f6d24f8658e0896c46e613aa656a853b358c321
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 16, 2025
apache/airflow#22137 (comment)

GitOrigin-RevId: 4f6d24f8658e0896c46e613aa656a853b358c321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants