Skip to content

Conversation

@ulsc
Copy link
Contributor

@ulsc ulsc commented Mar 11, 2022

Adding resumable=True parameter to MediaFileUpload gives the ability to upload files bigger than 5MB to Google Drive.

Adding `resumable=True` parameter to `MediaFileUpload` gives the ability to upload files bigger than 5MB to Google Drive.
@ulsc ulsc requested a review from turbaszek as a code owner March 11, 2022 12:27
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Mar 11, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 11, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@ulsc
Copy link
Contributor Author

ulsc commented Mar 12, 2022

Added chunk_size & resumable as parameters.

@potiuk
Copy link
Member

potiuk commented Mar 12, 2022

Right. I think unit tests cases in this case might be a bit over-the top :)

@ulsc
Copy link
Contributor Author

ulsc commented Mar 12, 2022

I'm preparing to push the Google Drive Operators I use, will probably cover these arguments in the test cases.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 13, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 4543539 into apache:main Mar 13, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 13, 2022

Awesome work, congrats on your first merged pull request!

@potiuk
Copy link
Member

potiuk commented Mar 13, 2022

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants