-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Support Uploading Bigger Files to Google Drive #22179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding `resumable=True` parameter to `MediaFileUpload` gives the ability to upload files bigger than 5MB to Google Drive.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
Added chunk_size & resumable as parameters. |
|
Right. I think unit tests cases in this case might be a bit over-the top :) |
|
I'm preparing to push the Google Drive Operators I use, will probably cover these arguments in the test cases. |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
|
Awesome work, congrats on your first merged pull request! |
|
Cool! |
Adding
resumable=Trueparameter toMediaFileUploadgives the ability to upload files bigger than 5MB to Google Drive.