Remove Snowflake limits #22181
Merged
Remove Snowflake limits #22181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
dstandish,
eladkal,
jedcunningham,
mik-laj and
turbaszek
Member
Author
|
This is the last "blocker" to add Python 3.10 BTW :) |
jedcunningham
approved these changes
Mar 11, 2022
Member
jedcunningham
left a comment
jedcunningham
left a comment
There was a problem hiding this comment.
Should we bump the lowers up too?
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
The limits of snowflake can be removed as the conditions for all limits are fulfilled now. This is the last thing to remove before we can enable Python 3.10
potiuk
force-pushed
the
remove-snowflake-limits
branch
from
b6780ed to
bdf4bc5
Compare
Member
Author
No need. There was no incompatible changes, so old versions of libraries will continue to work, we should only bump lower limits if we know there is an incompatibiliity. |
41 tasks
ephraimbuddy
added
the
type:misc/internal
ephraimbuddy
added
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limits of snowflake can be removed as the conditions for
all limits are fulfilled now.
This is the last thing to remove before we can enable Python 3.10
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.