Remove extra initialization overhead for mypy/flake #22183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
dstandish,
ephraimbuddy,
jedcunningham and
uranusjr
potiuk
force-pushed
the
fix-extra-mypy-flake-initialization
branch
2 times, most recently
from
a99e3b1 to
2339b80
Compare
jedcunningham
approved these changes
Mar 11, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
force-pushed
the
fix-extra-mypy-flake-initialization
branch
from
2339b80 to
5d546d8
Compare
The apache#22127 change introduced a change how execution of docker commnds was done (due to LD_PRELOAD change) and they started to use entrypoint_ci, however this caused undesired effect of running database initialization and printing extra lines which was not needed and cluttered the output. This PR introduced SKIP_ENVIRONMENT_INITIALIZATION that (if set to true) skips the entire initialization of the entrypoint_ci
potiuk
force-pushed
the
fix-extra-mypy-flake-initialization
branch
from
5d546d8 to
0cf3f6a
Compare
Member
Author
|
Random failure. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #22127 change introduced a change how execution of docker
commnds was done (due to LD_PRELOAD change) and they started to
use entrypoint_ci, however this caused undesired effect of running
database initialization and printing extra lines which was not needed
and cluttered the output.
This PR introduced SKIP_ENVIRONMENT_INITIALIZATION that (if set to true)
skips the entire initialization of the entrypoint_ci
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.