Skip to content

Conversation

@ferruzzi
Copy link
Contributor

Cleans up the existing sample DAG and docs for the EMR operators.
Part of a project to simplify and standardize AWS sample dags and docs in preparation for adding System Testing.

Related: #21523
Related: #21475
Related: #21828
Related: #21920
etc...


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Comment on lines +52 to +54
'Market': 'ON_DEMAND',
'InstanceRole': 'MASTER',
'InstanceType': 'm1.medium',
'InstanceType': 'm5.xlarge',
Copy link
Contributor Author

@ferruzzi ferruzzi Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note since I'm sure someone will ask; Here and below, these are the new default/recommended settings. The m1 series instance types are "previous generation" and no longer recommend.

@ferruzzi
Copy link
Contributor Author

@eladkal has looked at most/all of the previous related ones. Tagging in case he wants to keep up with it or pass. 👍

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 14, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 46c61ed into apache:main Mar 14, 2022
@potiuk
Copy link
Member

potiuk commented Mar 14, 2022

Another one for next provider's release :)

@ferruzzi ferruzzi deleted the ferruzzi/docs-update/emr branch March 14, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants