ci prepare-build-cache

[Bowrna]

closes : #21102
related: #21102

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

[Bowrna]

@potiuk
--cache:max should be added also in the CI image (because it is multi-segment image now)
#22492 (comment)

I will add this as part of this PR.

[Bowrna]

@potiuk i want to know how we can pass the CI flag in python? In bash we set it as env var. Do we need to pass that as flag when we rewrite in python?

airflow/scripts/ci/libraries/_build_images.sh

Lines 454 to 463 in c58b5e5

	if [[ ${CI} == "true" ]]; then
	EXTRA_DOCKER_PROD_BUILD_FLAGS+=(
	"--build-arg" "PIP_PROGRESS_BAR=off"
	)
	fi
	if [[ -n "${AIRFLOW_CONSTRAINTS_LOCATION}" ]]; then
	extra_docker_ci_flags+=(
	"--build-arg" "AIRFLOW_CONSTRAINTS_LOCATION=${AIRFLOW_CONSTRAINTS_LOCATION}"
	)
	fi

[Bowrna]

@potiuk I made changes specified in this #22618
Please verify it

[Bowrna]

@potiuk i want to know how we can pass the CI flag in python? In bash we set it as env var. Do we need to pass that as flag when we rewrite in python?

airflow/scripts/ci/libraries/_build_images.sh

Lines 454 to 463 in c58b5e5

	if [[ ${CI} == "true" ]]; then
	EXTRA_DOCKER_PROD_BUILD_FLAGS+=(
	"--build-arg" "PIP_PROGRESS_BAR=off"
	)
	fi
	if [[ -n "${AIRFLOW_CONSTRAINTS_LOCATION}" ]]; then
	extra_docker_ci_flags+=(
	"--build-arg" "AIRFLOW_CONSTRAINTS_LOCATION=${AIRFLOW_CONSTRAINTS_LOCATION}"
	)
	fi

@potiuk Please share your view on this when you get time.

[potiuk]

Suggested change

	upgrade_to_newer_dependencies: bool,
	upgrade_to_newer_dependencies: bool,

This should be Optional[str] actually :)

[potiuk]

That was the fix I made here -> #22597

[Bowrna]

@potiuk Is it Optional[str] for prod image too?

[potiuk]

Yep

[potiuk]

I added more fixes on the parameter in #22649 :). You will need to rebase and resolve conflicts :)

[potiuk]

@potiuk i want to know how we can pass the CI flag in python? In bash we set it as env var. Do we need to pass that as flag when we rewrite in python?

airflow/scripts/ci/libraries/_build_images.sh

Lines 454 to 463 in c58b5e5

	if [[ ${CI} == "true" ]]; then
	EXTRA_DOCKER_PROD_BUILD_FLAGS+=(
	"--build-arg" "PIP_PROGRESS_BAR=off"
	)
	fi
	if [[ -n "${AIRFLOW_CONSTRAINTS_LOCATION}" ]]; then
	extra_docker_ci_flags+=(
	"--build-arg" "AIRFLOW_CONSTRAINTS_LOCATION=${AIRFLOW_CONSTRAINTS_LOCATION}"
	)
	fi

@potiuk Please share your view on this when you get time.

Same as in Bash. Just add the PIP_PROGRESS_BAR==off if CI is set to true. There is no need to pass it further. But in order to do it nicely you can add --ci parameter with CI envvar via click.

[Bowrna]

@potiuk Added fix for flag upgrade_to_newer_dependencies :)

[Bowrna]

@potiuk i want to know how we can pass the CI flag in python? In bash we set it as env var. Do we need to pass that as flag when we rewrite in python?

airflow/scripts/ci/libraries/_build_images.sh

Lines 454 to 463 in c58b5e5

	if [[ ${CI} == "true" ]]; then
	EXTRA_DOCKER_PROD_BUILD_FLAGS+=(
	"--build-arg" "PIP_PROGRESS_BAR=off"
	)
	fi
	if [[ -n "${AIRFLOW_CONSTRAINTS_LOCATION}" ]]; then
	extra_docker_ci_flags+=(
	"--build-arg" "AIRFLOW_CONSTRAINTS_LOCATION=${AIRFLOW_CONSTRAINTS_LOCATION}"
	)
	fi

@potiuk Please share your view on this when you get time.

Same as in Bash. Just add the PIP_PROGRESS_BAR==off if CI is set to true. There is no need to pass it further. But in order to do it nicely you can add --ci parameter with CI envvar via click.

@potiuk Added this support too

[joppevos]

I assume it should be "...will TURN off the pip..."? :)