-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Adds HiveToDynamoDB Transfer Sample DAG and Docs #22517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds HiveToDynamoDB Transfer Sample DAG and Docs #22517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed this from others as I go through them, but in this case I thought it was a nice touch to add a disclaimer that the DAG won't run without prior setup. I can remove it if we would rather keep it uniform.
1dc40ec to
9b17c38
Compare
|
Gah. PyCharm flagged that as a warning but it passed the local CI ( |
|
Looks like chain() doesn't like @task decorated methods. Posted to the Slack server to discuss fix: https://apache-airflow.slack.com/archives/CCPRP7943/p1648498867915099 Option1) Convert the @tasks to PythonOperators. |
Followed by
In separate PR :) |
|
Created an Issue for it. If someone else gets to it before me then even better: #22594 |
012beeb to
d1a1490
Compare
|
Rebased and fixed the chain() notation to bitwise for 2.1 compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should convert this to TaskFlow API as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't figure out a way to do it with the trigger_rule. I had tried @task(trigger_rule='all_done') as seen in 36368e96d3543e5ae873f135808d50f29cbfbcb6 but that fails static checks.
See: https://apache-airflow.slack.com/archives/CCPRP7943/p1648228076933559
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't that because using chain()with TaskFlow API was not compatible with Airflow 2.1? You should be able to pass a trigger_rule directly to the decorator like you're trying to do with Airflow 2.1+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I'll revert that and see. Maybe I just misread the error message. I'm in a meeting, but should have it pushed within the hour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That didn't age well. 😛 Rebased and pushed reversion.
d1a1490 to
04ef561
Compare
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
|
CI is green. That concludes this little adventure in misreading error messages. Thanks for the help Jarek and Josh. |
|
@ferruzzi - your adventure was very, vey little. Read THIS #22548 (comment) |
|
@potiuk It was an adventure, not an Oddesy 😛 |
Does what it says on the tin; adds sample dag and docs for an existing transfer.
Part of a project to simplify and standardize AWS sample dags and docs in preparation for adding System Testing.
Related: #21523
Related: #21475
Related: #21828
Related: #21920
etc...
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.