Support serviceAccount attr for dataflow in the Apache beam #23078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:Apache
provider:google
potiuk
reviewed
Apr 25, 2022
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
I think it needs a test modification. Running it now.
potiuk
approved these changes
Apr 25, 2022
Member
|
Ah no. |
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 11, 2022
Cherry-picked changes from the community: * apache/airflow#24416 * apache/airflow#23078 Unit tests executed: https://screenshot.googleplex.com/5AJvqmrXwoUA83L Dags executed: https://screenshot.googleplex.com/67ABr73jTfZETb7 Change-Id: I6f4795eed4a8ecc67b0f7997f228cd92d464d004 GitOrigin-RevId: 0fa3a13797a21cd5d6c3e08d315bb93f7af4e787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extended dataflow config to support
serviceAccountparameter and give users possibility to specify which service account should be used to execute Job in the Dataflow.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.