Skip to content

Conversation

@kosteev
Copy link
Contributor

@kosteev kosteev commented Apr 20, 2022

This change is follow-up to this change #15311 and #15464.

Basically this change assures that DAG specific permissions are revoked once access_control field is emptied for DAG.

closes: #17508
related: #8609

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Apr 20, 2022
@kosteev
Copy link
Contributor Author

kosteev commented Apr 20, 2022

@jedcunningham As you were author of related changes, please, take a look.

@kosteev
Copy link
Contributor Author

kosteev commented Apr 20, 2022

After a bit more thinking I actually realised the issue here.
The thing is that if we revoke permissions on access_control = None, that means it makes impossible to assign manually permissions on DAG resources to roles as they will be cleaned up after syncing DAG (if access_control is None).

@kosteev
Copy link
Contributor Author

kosteev commented Apr 22, 2022

It might be good idea to implement this change hidden under some Airflow configuration property.
Closing pull-request as of now, for the future discussion and making decision about implementation.

@kosteev kosteev closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing role name in access_control doesn't remove permission from previous role

1 participant