Skip to content

Conversation

@pavel-lexyr
Copy link
Contributor

This PR aims to fix a long-standing logging bug present in Airflow. In particular, any clusters of more than one worker do not handle their logs appropriately - always fetching files from the host used in the last run.

This change replaces the hostname field of the TaskInstance object with a list hostnames, storing a separate hostname for each run of the job.

This iteration is not final. If you have any comments, do not hesitate to post them.

In particular, the areas I am looking for feedback on are:

  • Is the AIP process necessary for this kind of change? If so, how would one ensure it goes smoothly?
  • What kinds of tests should be added?
  • A database migration is needed for this change. What is the appropriate way to implement one?

closes: #16472

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 20, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr
Copy link
Member

uranusjr commented Apr 22, 2022

Instead of trying to implicitly looking up the correct hostname based on try_number, it may be better to introduce a new table altogether to keep the (dag_id, task_id, run_id, try_number) -> hostname lookup. Or a dict (via JSON column).

@pavel-lexyr
Copy link
Contributor Author

That's a reasonable idea. I'll close and restart it as a different PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logging area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to fetch log file from worker because webserver did not search the right worker.

2 participants