Fix static-checks actually work after Breeze migration #23202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
Apr 24, 2022
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
potiuk
force-pushed
the
fix-typo-with-breeze-docs
branch
3 times, most recently
from
1810f21 to
b93d158
Compare
potiuk
force-pushed
the
fix-typo-with-breeze-docs
branch
2 times, most recently
from
4a1222c to
a3d78e2
Compare
potiuk
changed the title
Member
Author
|
Hey @eladkal -> I looked closely and I found that static chceks were not really "running" (but succeeded) - so I changed this PR as I used it as a "testing ground" - as this one "was" actually failing :) |
Member
Author
|
Glad I tested it over the weekend when we had very little number of PRs :) |
Static checks were not really "enabled' after migration since apache#23193 This PR fixes it.
potiuk
force-pushed
the
fix-typo-with-breeze-docs
branch
2 times, most recently
from
5c7d913 to
da4a741
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static checks were not really "enabled' after migration since #23193
This PR fixes it.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.