Skip to content

Conversation

@sp1thas
Copy link

@sp1thas sp1thas commented Apr 25, 2022

Co-authored-by: mingshi mingshi.wang@coinbase.com

closes: #23124
related: #20781

Based on the discussion we had on #23124 , the purpose of this PR is to cherry-pick 82e466d in order to disable the DeprecationWarning on v2.2-stable

Co-authored-by: mingshi <mingshi.wang@coinbase.com>
@sp1thas sp1thas requested review from kaxil and mik-laj as code owners April 25, 2022 09:47
@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Apr 25, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 25, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal
Copy link
Contributor

eladkal commented Apr 25, 2022

I don't think we are going to have more releases for 2.2
@jedcunningham ?

@jedcunningham
Copy link
Member

Yeah, I'd say it's extremely unlikely we have another 2.2 release at this point. 2.3 is right around the corner now.

Thanks for being proactive and opening this PR though @sp1thas, I appreciate it 🍺

Even if we did do another 2.2 though, we do a cherry-pick with the -x flag to keep a proper history. In most cases, getting a PR in the next milestone is enough - the release manager (or less commonly another committer) would do the cherry-pick manually as part of the release process. So in this case, we'd just need to ask in slack or in the original PR to get #20781 in the next 2.2.x milestone.

Sorry that it was missed and didn't get picked up in a patch release. If you spot this in the future, let us know and we will get it in the next release (most likely).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants