-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add Task Logs to Grid details panel #24249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Task Logs to Grid details panel #24249
Conversation
94fe6e0 to
701ccc9
Compare
|
I just updated the PR, as suggested:
Also added:
|
97bc171 to
8b14dbd
Compare
airflow/www/static/js/grid/details/content/taskInstance/Logs/index.jsx
Outdated
Show resolved
Hide resolved
|
In a separate PR, before or after, we should make the grid only as big as it needs to be and the details panel can grow to take up the rest of the page (inverse of today). The logs textarea gets cramped as it is now. |
airflow/www/static/js/grid/details/content/taskInstance/Logs/index.jsx
Outdated
Show resolved
Hide resolved
551e858 to
41302cc
Compare
airflow/www/static/js/grid/details/content/taskInstance/Logs/index.jsx
Outdated
Show resolved
Hide resolved
airflow/www/static/js/grid/details/content/taskInstance/Logs/index.jsx
Outdated
Show resolved
Hide resolved
It might be cool to make the panel resizeable. |
cbf78ad to
d31b1ed
Compare
airflow/www/static/js/grid/details/content/taskInstance/Logs/LogLink.test.jsx
Outdated
Show resolved
Hide resolved
bbovenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
4dad6f7 to
30935ba
Compare
|
Thank you for the reviews and the improvement suggestions. The branch is rebased :) |
|
Will this included in 2.3.4 or a 2.4.0? |
|
@NilsJPWerner 2.4.0, its certainly not a bug fix that we can sneak into a patch release. but 2.4.0 will come out far quicker than 2.3.0 did. |
|
Fantastic! I'm pumped for this feature! Do you think the graphs refresh will make it in as well? |
|
That's the plan! |


closes: #23503
First draft to discuss changes and precise UI requirements for this.Some of the changes:
Split metadata details into two columns for smaller vertical spaceFor the request URL, I can pass it into the metadata to be able to do something like:But then I have to manually replace_DAG_RUN_ID,_TASK_ID_,_TASK_TRY_NUMBER. What's the best way to handle that ?^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.