-
Notifications
You must be signed in to change notification settings - Fork 16.4k
TI.log_url fix for map_index
#24335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TI.log_url fix for map_index
#24335
Conversation
|
Note - my local breeze tests may not have been working correctly. I had failures but mostly with |
|
This could definitely use some more unhappy-path tests. That required a slight overhaul to some of the pytest fixtures, so I didn't undertake it yet |
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
|
build failure appears to be unrelated to my code, |
|
Merged @fritz-astronomer :) - it was indeed intermittent failure. |
closes: #24328
related: #24328
Adds
map_indexto thetask_instance.log_urllink, which fixes a bug previously that prevented logs being displayed correctly at the link given.