Mask secrets in stdout for CLI command #24362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
17476-secret-redact-cli-test
branch
from
caacbbb to
2ca3208
Compare
A stdout redirector is implemented to mask all values to stdout and redact any secrets in it with the secrets masker. This redirector is applied to the 'airflow.task' logger.
uranusjr
force-pushed
the
17476-secret-redact-cli-test
branch
from
2ca3208 to
79e2f34
Compare
4 tasks
potiuk
approved these changes
Jun 12, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Jul 5, 2022
A stdout redirector is implemented to mask all values to stdout and redact any secrets in it with the secrets masker. This redirector is applied to the 'airflow.task' logger. Co-authored-by: Alex Kennedy <alex.kennedy@astronomer.io> (cherry picked from commit 3007159)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jul 5, 2022
A stdout redirector is implemented to mask all values to stdout and redact any secrets in it with the secrets masker. This redirector is applied to the 'airflow.task' logger. Co-authored-by: Alex Kennedy <alex.kennedy@astronomer.io> (cherry picked from commit 3007159)
74 tasks
Member
|
@dimberman we should add similar redaction on the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #21281, but rebased and simplified.
Close #21281, fix #17476.