Add parameter to turn off SQL query logging #24570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
reviewed
Jun 21, 2022
potiuk
reviewed
Jun 21, 2022
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Some user documentation would be handy,
Contributor
Author
|
@potiuk updated! |
uranusjr
reviewed
Jun 22, 2022
uranusjr
reviewed
Jun 22, 2022
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
holly-evans
commented
Jun 22, 2022
Contributor
Author
|
@uranusjr updated |
uranusjr
reviewed
Jun 23, 2022
tests/hooks/test_dbapi.py
Outdated
| return conn | ||
|
|
||
| self.db_hook = UnitTestDbApiHook() | ||
| self.db_hook_log_sql = UnitTestDbApiHook(log_sql=False) |
Member
There was a problem hiding this comment.
Suggested change
| self.db_hook_log_sql = UnitTestDbApiHook(log_sql=False) | |
| self.db_hook_no_log_sql = UnitTestDbApiHook(log_sql=False) |
This should be clearer? But since this is only used by one test, it’s better to simply instantiate the hook in that test instead.
Contributor
Author
There was a problem hiding this comment.
@uranusjr Sure, I can rename it. I instantiate the hook here because UnitTestDbApiHook is defined here, I could pull it out perhaps? Also db_hook_schema_override is only used in one test and defined here, so I kept that pattern.
Member
There was a problem hiding this comment.
A lot of the provider tests are historically suboptimally written, they don’t always serve as good style guides 🙂
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
potiuk
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #11618
DbApiHookacceptslog_sqlkwarg to turn off logging the SQL query. InBaseSQLOperator,hook_kwargsflows through to the hook, includinglog_sql.