Grid task log, multi select and ts files migration. #24623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
ashb,
bbovenzi and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:UI
pierrejeambrun
force-pushed
the
grid-view-logs-multi-select-on-level
branch
4 times, most recently
from
6873cb1 to
69eb029
Compare
bbovenzi
reviewed
Jun 24, 2022
pierrejeambrun
force-pushed
the
grid-view-logs-multi-select-on-level
branch
2 times, most recently
from
71ca55f to
c442e61
Compare
Contributor
|
The font colors aren't matching. Don't we want the multi-select for the file source too? |
Member
Author
Yes I was wondering that too, I can add the multi select there. |
pierrejeambrun
force-pushed
the
grid-view-logs-multi-select-on-level
branch
from
1b92c31 to
9ac16b3
Compare
Contributor
|
Let's update the |
pierrejeambrun
force-pushed
the
grid-view-logs-multi-select-on-level
branch
2 times, most recently
from
fb39ca9 to
5412239
Compare
bbovenzi
approved these changes
Jun 28, 2022
Contributor
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
nice work! this keeps becoming a more useful view
pierrejeambrun
force-pushed
the
grid-view-logs-multi-select-on-level
branch
from
5412239 to
3f715e5
Compare
potiuk
force-pushed
the
grid-view-logs-multi-select-on-level
branch
from
3f715e5 to
0e2b099
Compare
pierrejeambrun
force-pushed
the
grid-view-logs-multi-select-on-level
branch
from
0e2b099 to
d5a984c
Compare
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #24403.
@bbovenzi , we discussed about removing colors in the drop down. Adding colors inside the logs is not trivial. Even without colors in the logs, I think the left border in the drop down makes it easier to identify the level we are looking for.
I will happily change the style depending on your feedback.
Edit: Converting to draft, not ready. I would like to also migrate associated test file to ts in this PR.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.