Skip to content

Conversation

@blag
Copy link
Contributor

@blag blag commented Jun 24, 2022

This is part of a series of PRs breaking up #22613 into smaller, more reviewable chunks. The end result will be rewriting the existing airflow CLI to use Click instead of argparse. For motivation, please see #22708.

This PR adds the celery subcommand to the airflow-ng command. It's exactly the same as the airflow celery command, it's just implemented with Click. This PR also includes an additional, separate test file for the Click celery subcommand. The intent there is to simply remove the test files for the old commands once the Click-based airflow-ng command supersedes and replaces the argparse-based airflow command.

For comparison to the modules this supersedes:

Original author: @hankehly astronomer#1495

@blag
Copy link
Contributor Author

blag commented Jun 24, 2022

@hankehly Can I get your 👍 on this?

@blag blag closed this Jul 1, 2022
@blag blag deleted the convert-celery-command-to-click branch July 1, 2022 21:09
@blag
Copy link
Contributor Author

blag commented Jul 1, 2022

From this discussion, there is more groundwork and research necessary before we can evaluate rewriting the CLI with Click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants