Allows to specify different Python base image when building images #24634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
add-python-base-image-command
branch
2 times, most recently
from
eb51d15 to
c5c4b91
Compare
Today Python released new images that seems to break some of our dependencies (at least on M1/ARM). This PR adds a workaround possibility to add --python-image option to override the default, latest image with any other version released previously until we diagnose and fix the real issue.
potiuk
force-pushed
the
add-python-base-image-command
branch
from
c5c4b91 to
ee14d0e
Compare
Member
Author
|
Might be useful in the future in case Python base image break something (we thought it was the case today but it turned out to be amqp on ARM). |
jedcunningham
approved these changes
Jun 24, 2022
github-actions
bot
added
the
okay to merge
|
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 29, 2022
…pache#24634) Today Python released new images that seems to break some of our dependencies (at least on M1/ARM). This PR adds a workaround possibility to add --python-image option to override the default, latest image with any other version released previously until we diagnose and fix the real issue. (cherry picked from commit d6e6e7d)
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today Python released new images that seems to break some of
our dependencies (at least on M1/ARM). This PR adds a workaround
possibility to add --python-image option to override the
default, latest image with any other version released previously
until we diagnose and fix the real issue.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.