Fix selective checks to work for non-main-branch #24769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ashb,
jedcunningham,
kaxil and
mik-laj
as code owners
boring-cyborg
bot
added
area:dev-tools
area:providers
kind:documentation
provider:amazon
potiuk
force-pushed
the
add-fixes-for-non-main-branch-building
branch
5 times, most recently
from
ff8af57 to
6d57cd4
Compare
The recent changes in selective checks introduced a few problems
in non-main branches:
* constraints branch was not used by CI build in non-main branch
this was not a proble, (until it started to fail) because
other branches always work in "upgradeDepencies" case
* default branch calculation did not account for the selective-check
comment that was run before default branch was retrieved. Therefore
we did not run build as from 2.3 branch
* Some precomits should be skiped in non-main branch
* Integration was also excluded from Provider Check
* Two more commit outputs added:
* docs-filter - depends whether you are with more packages
* skip-pre-commit - allows to dynamically choose which pre-commits
should be skipped
potiuk
force-pushed
the
add-fixes-for-non-main-branch-building
branch
from
6d57cd4 to
9fa05ea
Compare
ephraimbuddy
approved these changes
Jul 1, 2022
potiuk
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Jul 1, 2022
The recent changes in selective checks introduced a few problems
in non-main branches:
* constraints branch was not used by CI build in non-main branch
this was not a proble, (until it started to fail) because
other branches always work in "upgradeDepencies" case
* default branch calculation did not account for the selective-check
comment that was run before default branch was retrieved. Therefore
we did not run build as from 2.3 branch
* Some precomits should be skiped in non-main branch
* Integration was also excluded from Provider Check
* Two more commit outputs added:
* docs-filter - depends whether you are with more packages
* skip-pre-commit - allows to dynamically choose which pre-commits
should be skipped
(cherry picked from commit c8d3850)
potiuk
added a commit
that referenced
this pull request
Jul 1, 2022
The recent changes in selective checks introduced a few problems
in non-main branches:
* constraints branch was not used by CI build in non-main branch
this was not a proble, (until it started to fail) because
other branches always work in "upgradeDepencies" case
* default branch calculation did not account for the selective-check
comment that was run before default branch was retrieved. Therefore
we did not run build as from 2.3 branch
* Some precomits should be skiped in non-main branch
* Integration was also excluded from Provider Check
* Two more commit outputs added:
* docs-filter - depends whether you are with more packages
* skip-pre-commit - allows to dynamically choose which pre-commits
should be skipped
(cherry picked from commit c8d3850)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes in selective checks introduced a few problems
in non-main branches:
constraints branch was not used by CI build in non-main branch
this was not a proble, (until it started to fail) because
other branches always work in "upgradeDepencies" case
default branch calculation did not account for the selective-check
that was run before default branch was retrieved. Therefore
we did not run build as from 2.3 branch. Now the branch is retrieved
before selective checks are run.
Some precomits should be skiped in non-main branch
Integration was also excluded additionally to Providers tests as
integration tests are not at all useful for non-main branch
Two more outputs added for selective checks:
should be skipped
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.