Choose the right builder when pushing to ghcr.io registry for cache #24780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pushing cache we cannot use default builder because it has no capability to push cache. We need to use airflow_cache for it, which has additionally the capacity of forwarding the builds to a remote ARM instance in case cache is built for ARM images too. Recently we added a new --builder flag to allow to choose the builder, but our scripts and CI have not been modified to account for that (previously builder was chosen automatically but that has proven to be limiting in some manual operations and it also allows to choose different names for builders in case someone wants to build their own pipeline of builds.
ephraimbuddy
approved these changes
Jul 1, 2022
potiuk
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Jul 1, 2022
…24780) When pushing cache we cannot use default builder because it has no capability to push cache. We need to use airflow_cache for it, which has additionally the capacity of forwarding the builds to a remote ARM instance in case cache is built for ARM images too. Recently we added a new --builder flag to allow to choose the builder, but our scripts and CI have not been modified to account for that (previously builder was chosen automatically but that has proven to be limiting in some manual operations and it also allows to choose different names for builders in case someone wants to build their own pipeline of builds. (cherry picked from commit a1679be)
potiuk
added a commit
that referenced
this pull request
Jul 1, 2022
…24780) When pushing cache we cannot use default builder because it has no capability to push cache. We need to use airflow_cache for it, which has additionally the capacity of forwarding the builds to a remote ARM instance in case cache is built for ARM images too. Recently we added a new --builder flag to allow to choose the builder, but our scripts and CI have not been modified to account for that (previously builder was chosen automatically but that has proven to be limiting in some manual operations and it also allows to choose different names for builders in case someone wants to build their own pipeline of builds. (cherry picked from commit a1679be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pushing cache we cannot use default builder because it has
no capability to push cache. We need to use airflow_cache for it,
which has additionally the capacity of forwarding the builds
to a remote ARM instance in case cache is built for ARM images
too. Recently we added a new --builder flag to allow to choose
the builder, but our scripts and CI have not been modified to
account for that (previously builder was chosen automatically but
that has proven to be limiting in some manual operations and it
also allows to choose different names for builders in case
someone wants to build their own pipeline of builds.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.