Fix exception in mini task scheduler. #24865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I introduced a bug in 2.3.0 as part of the dynamic task mapping work that frequently made the mini scheduler fail for tasks involving XComArgs. The fix is to alter the logic in BaseOperator's deepcopy to not set the `__instantiated` flag until all the other attributes are copied. For background the `__instantiated` flag is use so that when you do `task.some_attr = an_xcom_arg` the relationships are set appropriately, but since we are copying all the existing attributes we don't need to do that, as the relationships will already be set!
ephraimbuddy
approved these changes
Jul 6, 2022
potiuk
approved these changes
Jul 6, 2022
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Nice one! Bisect to the rescue :)
kaxil
approved these changes
Jul 6, 2022
Member
Author
|
Looks like a random failure of mysql? |
Member
|
Hmm since this is also related to copy behaviorr I kind of wonder if it is actually also the related to that other issue on MappedOperator. But we should be good now anyway after fixing them both now (there’s not a third kind of operator). |
ephraimbuddy
pushed a commit
that referenced
this pull request
Jul 6, 2022
I introduced a bug in 2.3.0 as part of the dynamic task mapping work that frequently made the mini scheduler fail for tasks involving XComArgs. The fix is to alter the logic in BaseOperator's deepcopy to not set the `__instantiated` flag until all the other attributes are copied. For background the `__instantiated` flag is use so that when you do `task.some_attr = an_xcom_arg` the relationships are set appropriately, but since we are copying all the existing attributes we don't need to do that, as the relationships will already be set! (cherry picked from commit c23b31c)
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a bug in 2.3.0 as part of the dynamic task mapping work
that frequently made the mini scheduler fail for tasks involving
XComArgs.
The fix is to alter the logic in BaseOperator's deepcopy to not set the
__instantiatedflag until all the other attributes are copied.For background the
__instantiatedflag is use so that when you dotask.some_attr = an_xcom_argthe relationships are set appropriately,but since we are copying all the existing attributes we don't need to do
that, as the relationships will already be set!
Fixes #24525