Add revisionHistoryLimit to all deployments

[csp33]

closes: #25058

We can use this parameter to control how many old ReplicaSets we want to retain for each deployment.

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[potiuk]

Makes sense - but should not it be possible to define also "global" revisionHistoryLimit that would override all "detailed" ones if not set? That would be easier to control @jedcunningham @ephraimbuddy @dstandish ?

[csp33]

yeah, that makes sense. I will update this PR with that global value

[csp33]

Done @potiuk
We can now specify revisionHistoryLimit both globally and inside every component. The value from each component has priority over the global one.

[potiuk]

LGTM. Anyone wants to take a look @jedcunningham @dstandish @ephraimbuddy ?

[jedcunningham]

@csp98, can you also add corresponding sections to values.yaml, e.g.

workers:
  replicas: 1
  revisionHistoryLimit: ~

You'll also have to add null to the allowed types, but I think most folks just look at values.yaml to see possible options so it's worth adding there as well.

[csp33]

Done @jedcunningham ;)

[potiuk]

Much nicer now.

[csp33]

Hi @potiuk, @jedcunningham
Some tests seem to be failing due to timeouts:

• https://github.com/apache/airflow/runs/7432610724?check_suite_focus=true#step:9:1346
• https://github.com/apache/airflow/runs/7432364524?check_suite_focus=true#step:9:8176

What's the way to proceed?
Thanks!

[jedcunningham]

I've restarted the failures, hopefully they pass this time around.

[csp33]

Cool @jedcunningham, thanks.
I also noticed that the branch is outdated (again 😅). Shall I rebase it when tests finish?

[jedcunningham]

No, you'll drive yourself crazy trying to keep up 👍. As long as it stays relatively up to date we are okay, plus we don't get a ton of chart changes anyways.

[potiuk]

No, you'll drive yourself crazy trying to keep up +1. As long as it stays relatively up to date we are okay, plus we don't get a ton of chart changes anyways.

Well. Actually rebasing PR is a daily routine I do. The more often you do it, the less painful it is, and the easier it is. And you learn how to rebase quickly even if you have conflicts. This might sound counter-intiuitive but it actually works.

So contrary to what @jedcunningham said - yeah, by all means, rebase early, rebase often.

[potiuk]

😛

[boring-cyborg]

Awesome work, congrats on your first merged pull request!

[jedcunningham]

Daily, sure, but it was already rebased 3 hours ago 🙃

Thanks @csp98! Congrats on your first commit 🎉

[csp33]

Thank you all @potiuk @jedcunningham
My concern was not the rebase itself, but all the tests having to run again (after another approval) ;)

[potiuk]

Right. I sometimes rebase few times an hour (but only when I fix something) rebasing without change is indeed not needed (mostly). Unless there is an important change in main that is.