Speed up Kubernetes upgrade tests at least 2x #25159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
added
the
full tests needed
potiuk
changed the title
potiuk
force-pushed
the
speed-up-upgrade-kubernetes-tests-5-times-in-main
branch
from
157d848 to
47d4c2c
Compare
potiuk
force-pushed
the
speed-up-upgrade-kubernetes-tests-5-times-in-main
branch
from
47d4c2c to
cf9ec97
Compare
Member
Author
|
Running 🤞 |
Member
Author
|
@jedcunningham @ephraimbuddy - 19m instead of 41m -> not bad at all. I am just going to push an update to the name of the job but I believe this one is good to go. |
potiuk
force-pushed
the
speed-up-upgrade-kubernetes-tests-5-times-in-main
branch
from
cf9ec97 to
d7b57f4
Compare
jedcunningham
approved these changes
Jul 19, 2022
We do not need to run upgrade kubernetes tests for all python versions and all kubernetes versions. It is enough to run them for the minimum and maximum versions. We already run all k8s tests in main for all executors, so they "generally" work, and it is very, very unlikely that if it works for Python 3.7, and 3.10, it will not work for 3.8 or 3.9 (similarly for K8S version). This will speed up the build at least 2 times.
potiuk
force-pushed
the
speed-up-upgrade-kubernetes-tests-5-times-in-main
branch
from
d7b57f4 to
873a3db
Compare
potiuk
added a commit
that referenced
this pull request
Jul 21, 2022
We do not need to run upgrade kubernetes tests for all python versions and all kubernetes versions. It is enough to run them for the minimum and maximum versions. We already run all k8s tests in main for all executors, so they "generally" work, and it is very, very unlikely that if it works for Python 3.7, and 3.10, it will not work for 3.8 or 3.9 (similarly for K8S version). This will speed up the build at least 2 times. (cherry picked from commit 907e720)
ephraimbuddy
added
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need to run upgrade kubernetes tests for all python
versions and all kubernetes versions. It is enough to run them
for the minimum and maximum versions. We already run all k8s tests
in main for all executors, so they "generally" work, and it
is very, very unlikely that if it works for Python 3.7, and 3.10,
it will not work for 3.8 or 3.9 (similarly for K8S version).
This will speed up the build at least 2 times.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.