Add ts types generation to static checks

[pierrejeambrun]

Following #25123, allowing us to auto-generate typescript types for the api, here is a pre-commit hook to ensure that these types stay in sync with the OpenAPI spec.

Modifying the openapi/v1.yaml will trigger the type generation. (then could eventually break ESlint hook when attempting again to commit, in case of incompatible changes)

[bbovenzi]

looking great!

[bbovenzi]

I merged my PR. Want to rebase and update the PR title and description?

[pierrejeambrun]

The PR has been updated, we should be good

[potiuk]

One small comment - it woudl be - I think - much better to merge this one with compile-www-assets - then same node env will be used and single yarn install command would be needed

[potiuk]

Those are triggered by different source files - but I think overall it would be more efficient.

[pierrejeambrun]

The compile-www-assets has a manual confined stage, should I extend this with commit ?

[potiuk]

Right.... Forgot about it 🤦 But the "lint" one does not :). This what Is actually better "typescript compile lint" sems like good idea

[potiuk]

On the other hand. isolation is better in this case rather than optimisation.

[pierrejeambrun]

Following your suggestions, here is another option that merges the generate-api-types hook into lint-javascript (+ renaming reflecting this change).

Let me know what version is preferable :)

[potiuk]

Let's change the description too.

[pierrejeambrun]

Yes I didn't change it cause we are limited in length :(, trying to find something better

[potiuk]

Generate and lint UI Javascript files ?

[pierrejeambrun]

I went for TS types generation and ESLint against current UI files (that is bellow < 70char) I wanted to remove the reference to Javascript as it is not really accurate anymore

[potiuk]

I think this one is better. In VAST majority of cases running 'generate-api-types' will produce the same file.

Unfortunately - unlike in Python, pre-commit does not reuse node environments, so the less of them, the better for time/cache restore and creation etc:

⌁ [jarek:~/.cache/pre-commit] % echo */*/lib/node_modules | xargs du -h -s
 21M	repocw333njc/node_env-18.6.0/lib/node_modules
 48M	repoltxx29sq/node_env-18.6.0/lib/node_modules
 19M	repowd9np_qb/node_env-18.6.0/lib/node_modules
 20M	repoy6z0rp4o/node_env-16.15.1/lib/node_modules

[pierrejeambrun]

Ok great thanks for the details :)

[potiuk]

BTW. Is it possible @pierrejeambrun - you also remove all the node versions 18.6.0 in all node pre-commits and only update the version in the "top-level" default_language_version? I just realized that we have it by looking at those cached envs.

[pierrejeambrun]

Done, using the default node version and updated it to 18.6.0

[potiuk]

Closed/reopened to rebuild as there was temp dockerhub failure.

[pierrejeambrun]

Closed/reopened to rebuild as there was temp dockerhub failure.

Thanks,

I didn't know that trick, I'm used to amending and repushing 😂

[potiuk]

Closed/reopened to rebuild as there was temp dockerhub failure.

Thanks,

I didn't know that trick, I'm used to amending and repushing 😂

That's what I do with my changes too :)