Prefix the dags in dataset example dags with example_dataset_ #25181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having dag1, dag2 etc was not telling much about the different dataset dags
Contributor
|
If there's renaming, I would be tempted to go a little further — something like "example_dataset_first", "example_dataset_second", "example_dataset_requires_first", etc … |
Contributor
Author
Updated with |
jedcunningham
approved these changes
Jul 20, 2022
dstandish
approved these changes
Jul 20, 2022
jedcunningham
added
changelog:skip
eladkal
added
area:data-aware-scheduling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having dag1, dag2, etc was not telling much about the different dataset dags
Before:
After:
