Skip to content

Update code examples from "classic" operators to taskflow #25657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uranusjr merged 13 commits into from
Aug 18, 2022
Merged

Update code examples from "classic" operators to taskflow #25657

uranusjr merged 13 commits into from
Aug 18, 2022

Conversation

@hankehly
Copy link
Contributor

@hankehly hankehly commented Aug 11, 2022 •
edited
Loading

Related: #25319

This PR replaces uses of PythonOperator with the @task TaskFlow decorator in faq, best practices and "index" documentation.

To view the updated docs in a browser:

  1. Build the docs
breeze build-docs --docs-only --package-filter apache-airflow
  1. Open docs/_build/docs/apache-airflow/latest/index.html in your browser

@hankehly hankehly marked this pull request as ready for review August 11, 2022 05:17
@hankehly hankehly requested review from kaxil and potiuk as code owners August 11, 2022 05:17
@hankehly hankehly mentioned this pull request Aug 11, 2022
Closed
10 tasks
@hankehly
Copy link
Contributor Author

hankehly commented Aug 11, 2022

@josh-fell @potiuk
Please see this at your earliest convenience.
If it looks OK I'll go ahead and update the remaining docs in a separate PR.

josh-fell
josh-fell reviewed Aug 15, 2022
View reviewed changes
Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for jumping in to update these! Just a few little comments.

hankehly and others added 2 commits August 16, 2022 08:47
@hankehly
Update best-practices.rst
3ac212f
@hankehly @josh-fell
Update docs/apache-airflow/index.rst
ec87ba4 
Co-authored-by: Josh Fell <48934154+josh-fell@users.noreply.github.com>
@hankehly
Copy link
Contributor Author

hankehly commented Aug 15, 2022

@josh-fell Please see updates. I'll get started on the remaining files.

uranusjr
uranusjr approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor (non-blocking) comment

@hankehly @uranusjr
Update docs/apache-airflow/faq.rst
8ab0f18 
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
@josh-fell
Copy link
Contributor

josh-fell commented Aug 17, 2022

@hankehly When you get a chance, can you address the static check errors please?

@uranusjr uranusjr changed the title Update code examples from "classic" operators to TaskFlow decorators (faq, best practices, index) Update code examples from "classic" operators to taskflow Aug 18, 2022
@uranusjr uranusjr merged commit 98aac5d into apache:main Aug 18, 2022
@hankehly hankehly deleted the issue-25319-hankehly-1 branch August 20, 2022 02:40
@jedcunningham jedcunningham added the type:doc-only Changelog: Doc Only label Sep 12, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.0 milestone Sep 14, 2022
@BasPH BasPH mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjr uranusjr uranusjr approved these changes

@josh-fell josh-fell josh-fell approved these changes

@kaxil kaxil Awaiting requested review from kaxil

@potiuk potiuk Awaiting requested review from potiuk

Assignees

No one assigned

Labels

kind:documentation type:doc-only Changelog: Doc Only

Projects

None yet

Milestone

Airflow 2.4.0

Development

Successfully merging this pull request may close these issues.

5 participants

@hankehly @josh-fell @uranusjr @ephraimbuddy @jedcunningham