Configurable umask to all deamonized processes. #25664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously had this for just the `celery worker` subcommand, this PR extends it to anything that can run in daemon mode
norm
reviewed
Aug 11, 2022
| @@ -671,7 +671,6 @@ def string_lower_type(val): | |||
| ARG_UMASK = Arg( | |||
| ("-u", "--umask"), | |||
| help="Set the umask of celery worker in daemon mode", | |||
Member
Author
There was a problem hiding this comment.
Not currently -- it's only used for the celery worker command -- the other commands don't have a --umask argument, they only use the config value.
norm
reviewed
Aug 11, 2022
ashb
commented
Aug 11, 2022
potiuk
approved these changes
Aug 11, 2022
norm
approved these changes
Aug 11, 2022
kaxil
approved these changes
Aug 11, 2022
jedcunningham
approved these changes
Aug 11, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 15, 2022
We previously had this for just the `celery worker` subcommand, this PR extends it to anything that can run in daemon mode (cherry picked from commit bf14d14)
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously had this for just the
celery workersubcommand, this PRextends it to anything that can run in daemon mode.
The old celery.worker_umask is still respected, but not shown in the config anymore.