Fix airflow-github needs-categorization tool handling of renamed files
#25670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
ashb,
jedcunningham and
potiuk
as code owners
ephraimbuddy
force-pushed
the
fix-needs-categorization
branch
2 times, most recently
from
3288553 to
3faf202
Compare
Renamed files are listed by github to start with `{old-filename} -> {new-filename}`.
Currently, these are treated as core files. Here we search the renamed files if it starts with what should be ignored
ephraimbuddy
force-pushed
the
fix-needs-categorization
branch
from
3faf202 to
ee3714f
Compare
potiuk
approved these changes
Aug 12, 2022
kaxil
approved these changes
Aug 12, 2022
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed files are listed by github to start with
{old-filename} -> {new-filename}.Currently, these are treated as core files. Here we search the renamed files if it starts with what should be ignored
This bug made us have all of AIP-47 PRs appear as core