Add redshift create cluster snapshot operator

[pankajastro]

Add RedshiftCreateClusterSnapshotOperator to create snapshot for a redshift cluster. by default, it won't wait for the cluster to be available.

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[kazanzhy]

Hi @pankajastro.
I think this is a good new Operator. But I think a new functionality could be added without the many separate operators.
For example, in RDS I added the parameter db_type which could be either 'instance' or 'cluster'. It gives the possibility to use a single operator for a very similar job.
It will be good even if you will add a kind of copy-paste from these PRs:

• Added Hook for Amazon RDS #20642
• Added AWS RDS operators #20907
• Added AWS RDS sensors #21231

[pankajastro]

Hi @pankajastro. I think this is a good new Operator. But I think a new functionality could be added without the many separate operators. For example, in RDS I added the parameter db_type which could be either 'instance' or 'cluster'. It gives the possibility to use a single operator for a very similar job. It will be good even if you will add a kind of copy-paste from these PRs:

• Added Hook for Amazon RDS #20642
• Added AWS RDS operators #20907
• Added AWS RDS sensors #21231

hmm, I liked the Idea but for Redshift, we already have operators like RedshiftPauseClusterOperator, RedshiftResumeClusterOperator etc. I want to add RedshiftCreateClusterSnapshotOperator and RedshiftDeleteClusterSnapshotOperator I can consolidate these two into one operator RedshiftClusterSnapshotOperator, or do you have some thoughts on which would be the existing potential operator where I can add this operator implementation?

[eladkal]

hmm, I liked the Idea but for Redshift, we already have operators like RedshiftPauseClusterOperator, RedshiftResumeClusterOperator etc. I want to add RedshiftCreateClusterSnapshotOperator and RedshiftDeleteClusterSnapshotOperator I can consolidate these two into one operator RedshiftClusterSnapshotOperator

We can deprecate operators if there is a need.
If we can generalize and make things simpler to use I think it's better but this is a judgment call per case.
@ferruzzi @o-nikolas @vincbeck can you share your thoughts on this?

While we are on it can we address also the todo (I'm not sure what was the intent on this):

airflow/airflow/providers/amazon/aws/hooks/redshift_cluster.py

Lines 76 to 77 in 9021c2b

	# TODO: Wrap create_cluster_snapshot
	def cluster_status(self, cluster_identifier: str) -> str:

[vincbeck]

I rather have several "small" operator than one which handles multiple use cases. I guess there can be some exceptions but here I dont mind having RedshiftCreateClusterSnapshotOperator and RedshiftDeleteClusterSnapshotOperator

[josh-fell]

Looks good. A few imports and docs to update.

[josh-fell]

Right. LGTM! Let's see what CI thinks.

[vincbeck]

Thanks for addressing so quickly my comments. I just left 2 minor comments

[vincbeck]

LGTM