Skip to content

Conversation

@Inetov
Copy link

@Inetov Inetov commented Aug 22, 2022

it's just renaming the log directory for Windows users can clone your repository.
Windows not allow ":" in file/directory name.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Aug 22, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 22, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk
Copy link
Member

potiuk commented Aug 22, 2022

You will have to also fix some tests most likely

@Inetov
Copy link
Author

Inetov commented Aug 22, 2022

You will have to also fix some tests most likely

I did not find in the code where this name / path to the file would be used

@Taragolis
Copy link
Contributor

Taragolis commented Aug 22, 2022

I did not find in the code where this name / path to the file would be used
https://github.com/apache/airflow/blob/main/tests/www/views/test_views_log.py

I don't think that is possible to change directory/filename seems like it test default log format.
However tests might create this files in temp directory.

Or windows users might run git config core.protectNTFS false before clone repo or better clone inside WSL 2

@uranusjr
Copy link
Member

It could possible to override this in tests with conf_var or something. But either way the “fix” would be more involved than just renaming.

@Inetov
Copy link
Author

Inetov commented Aug 22, 2022

I don't think that is possible to change directory/filename seems like it test default log format. However tests might create this files in temp directory.

Or windows users might run git config core.protectNTFS false before clone repo or better clone inside WSL 2

OK, thanks! this is harder than it seemed, I don't have time to finish it yet

@potiuk
Copy link
Member

potiuk commented Aug 26, 2022

Closing for now then

@potiuk potiuk closed this Aug 26, 2022
@Inetov Inetov deleted the fix-rename-directory branch August 30, 2022 13:08
@Inetov Inetov restored the fix-rename-directory branch August 30, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants