Fix command dags list-runs argument dag_id #25978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dag_id should be a positional argument.
potiuk
approved these changes
Aug 27, 2022
jedcunningham
added
the
changelog:skip
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Sep 14, 2022
This reverts commit ed6ea72.
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Sep 14, 2022
While it would ideal to transition to a positional arg like was attempted in apache#25978, this unfortunately does result in a breaking change so we cannot do it now. By instead marking the existing arg as required, we maintain backcompat while also providing a helpful error message to the user if they forget it.
jedcunningham
added a commit
that referenced
this pull request
Sep 14, 2022
While it would ideal to transition to a positional arg like was attempted in #25978, this unfortunately does result in a breaking change so we cannot do it now. By instead marking the existing arg as required, we maintain backcompat while also providing a helpful error message to the user if they forget it. This reverts commit ed6ea72.
jedcunningham
added a commit
that referenced
this pull request
Sep 15, 2022
While it would ideal to transition to a positional arg like was attempted in #25978, this unfortunately does result in a breaking change so we cannot do it now. By instead marking the existing arg as required, we maintain backcompat while also providing a helpful error message to the user if they forget it. This reverts commit ed6ea72. (cherry picked from commit f6c579c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The below exception is thrown when the list-runs argument is not set
DAG: None does not exist in the 'DAG' table
So I think dag_id should be a positional argument
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.