Skip to content

Conversation

@cra
Copy link
Contributor

@cra cra commented Sep 1, 2022

Hello

This PR contains the following:

  • adds more examples and explicit mention of imports of WeekDay enum in BranchDayOfWeekOperator.
  • adds back reference to now-deprecated kwarg, mentions that you should not use it (I saw something similar in the docs for other deprecated params and would think it's a good idea to have it in the docs since it's in the constructor)
  • adds more tasks in dag example for BranchDayOfWeekOperator so it's hopefully clearer on how to use WeekDay enum.
  • somewhat code-affecting change: adds type hints for the weekday sensor. I also updated hints for the week_day so it has the enum in it

It all should add more examples to both HowTo for the operator and the operator/sensor description in the docs

closes: #26071

Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
@cra cra requested a review from kaxil September 3, 2022 12:52
@potiuk
Copy link
Member

potiuk commented Sep 9, 2022

Nice one!

@potiuk potiuk merged commit dd6b2e4 into apache:main Sep 9, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 9, 2022

Awesome work, congrats on your first merged pull request!

@eladkal eladkal added this to the Airflow 2.4.1 milestone Sep 9, 2022
jedcunningham pushed a commit that referenced this pull request Sep 12, 2022
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:improvement Changelog: Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BranchDayOfWeekOperator documentation don't mention how to use parameter use_taks_execution_day or how to use WeekDay

6 participants