Add missing contrib classes to deprecated dictionaries #26179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The apache#26153 missed the classes that were added by deriving a new class from the imported ones. This was mostly about non-consistent spelling of class names. This PR fixes it and brings missing contrib classes back.
potiuk
force-pushed
the
add-missing-contrib-classes
branch
from
3823b5b to
5471472
Compare
potiuk
commented
Sep 6, 2022
| warnings.warn("This module is deprecated. Please use `airflow.utils`.", DeprecationWarning, stacklevel=2) | ||
|
|
||
| __deprecated_classes = { | ||
| 'aws_athena_hook': { |
Member
Author
There was a problem hiding this comment.
This was copy&pasted by mistake :(
Member
Author
|
It's also black-formatted, so there are some extra parentheses added automatically by black to keep the line length. |
Member
Author
|
Would love that one too ... it makes airflow code so mych nicer to browse and understand what's still there in the "core". |
josh-fell
approved these changes
Sep 7, 2022
ashb
approved these changes
Sep 7, 2022
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #26153 missed the classes that were added by deriving a new
class from the imported ones. This was mostly about non-consistent
spelling of class names.
This PR fixes it and brings missing contrib classes back.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.