Skip to content

Conversation

@syedahsn
Copy link
Contributor

@syedahsn syedahsn commented Sep 6, 2022

Consolidate Redshift system tests into one test, following the template in #24643.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@syedahsn syedahsn requested a review from mik-laj as a code owner September 7, 2022 16:33
@syedahsn syedahsn force-pushed the syedahsn/redshift-sql-system-test branch from 19824ef to 7c66aca Compare September 9, 2022 18:36
@potiuk
Copy link
Member

potiuk commented Sep 18, 2022

Approved, but it has conflicts that need to be removed.

…Group to allow access

 - Add template field to RedshiftHook
 - Add template field to RedshiftCreateClusterOperator
 - Add template field to RedshiftSQLOperator
 - Make some changes requested by Dennis regarding formatting
…t to reduce resource creation overhead.

Change RedshiftDeleteClusterOperator to use boto3 API waiter
Change RedshiftPauseClusterOperator and RedshiftResumeClusterOperator to raise Exception on failure
…redshift.py

Remove documentation references to deleted files.
Use RedshiftCreateClusterSnapshotOperator and RedshiftDeleteClusterSnapshotOperator instead of custom tasks.
@syedahsn syedahsn force-pushed the syedahsn/redshift-sql-system-test branch from 7c66aca to 71d400b Compare September 19, 2022 16:47
@potiuk potiuk merged commit 956ea7c into apache:main Sep 21, 2022
@vandonr-amz vandonr-amz deleted the syedahsn/redshift-sql-system-test branch May 24, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants