Fix 'from airflow import version' lazy import #26239
Merged
+20
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
lazy-loading-top-level-revise
branch
2 times, most recently
from
03c132d to
3ee6e12
Compare
This incorrectly accesses the version *attribute* in airflow.version instead of the airflow.version module itself, breaking compatibility. I actually rewrote the entire __getattr__ hook; much of the logic seems to be quite redundant.
uranusjr
force-pushed
the
lazy-loading-top-level-revise
branch
from
3ee6e12 to
411feaf
Compare
2 tasks
Member
|
Tested all combinations. Looks good. |
potiuk
approved these changes
Sep 8, 2022
ashb
approved these changes
Sep 9, 2022
ashb
pushed a commit
that referenced
this pull request
Sep 9, 2022
This incorrectly accesses the version *attribute* in airflow.version instead of the airflow.version module itself, breaking compatibility. I actually rewrote the entire __getattr__ hook; much of the logic seems to be quite redundant. (cherry picked from commit b7a603c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorrectly accesses the version attribute in
airflow.versioninstead of theairflow.versionmodule itself, breaking compatibility.I actually rewrote the entire
__getattr__hook; much of the logic seems to be quite redundant.Fix #26238.