Skip overriding version from parameter with the one from tag #26244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are not always updating the version suffix in code (rc1/rc2/b1/b2), the tag specified via --tag-build prefix should override the one in code rathe than the other way round. So what's left now - we will just print warning if the suffix does not match.
Member
|
Let me make sure I follow correctly. Code has 2.4.0.dev0, version suffix is 2.4.0rc1/rc1, code keeps dev0, package gets rc1? |
Member
Author
|
Correct . Suffix passed at preparation (rc1) will override whatever suffix is in the code (.dev0). Later on when we release 2.4.0, we usually don't bother to switch to .dev0 so rc1/rc2 will be just adding suffix rather than replacing it |
jedcunningham
approved these changes
Sep 8, 2022
potiuk
added a commit
that referenced
this pull request
Sep 8, 2022
Since we are not always updating the version suffix in code (rc1/rc2/b1/b2), the tag specified via --tag-build prefix should override the one in code rathe than the other way round. So what's left now - we will just print warning if the suffix does not match. (cherry picked from commit 9cf6f6a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are not always updating the version suffix in code (rc1/rc2/b1/b2), the tag specified via --tag-build prefix should override the one in code rathe than the other way round.
So what's left now - we will just print warning if the suffix does not match.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.